Skip to content

feat(client-presence): Latest support beyond object #24417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

feat(client-presence): Latest support beyond object #24417

merged 2 commits into from
Apr 22, 2025

Conversation

jason-ha
Copy link
Contributor

  • Latest now supports null initially and as a union type element
  • LatestMap now supports serializable primitives and null as well

@jason-ha
feat(client-presence): Latest support beyond object
f8f0f81 
- `Latest` now supports `null` initially and as a union type element
- `LatestMap` now supports serializable primitives as well
@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 00:28
@jason-ha jason-ha requested a review from a team as a code owner April 22, 2025 00:28
@jason-ha jason-ha requested review from nmsimons, tylerbutler and WillieHabi and removed request for Copilot April 22, 2025 00:28
@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct changeset-present base: main PRs targeted against main branch labels Apr 22, 2025
@github-actions github-actions bot added the public api change Changes to a public API label Apr 22, 2025
tylerbutler
tylerbutler approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits

packages/framework/presence/src/test/latestValueManager.spec.ts
@@ -19,6 +19,8 @@ import { StateFactory } from "@fluidframework/presence/alpha";

const testWorkspaceName = "name:testWorkspaceA";

/* eslint-disable unicorn/no-null */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add an explanation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b/c the rule is largely dumb?
I merged so resolutions can start happening and can add comment later.
I don't really know why we have this rule on. It seems we can just use null appropriately. It does have uses and it is more annoying to deal with the rule, IMO.

@github-actions GitHub Actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  163664 links
    1315 destination URLs
    1547 URLs ignored
       0 warnings
       0 errors

@jason-ha jason-ha merged commit 619af0b into microsoft:main Apr 22, 2025
38 checks passed
@jason-ha jason-ha deleted the presence/acceptMoreValues branch April 22, 2025 05:04
@github-actions github-actions bot mentioned this pull request Apr 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

@nmsimons nmsimons Awaiting requested review from nmsimons

@WillieHabi WillieHabi Awaiting requested review from WillieHabi

Assignees
No one assigned
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-ha @tylerbutler